Skip to content

Update libzim 9.7.0#201

Open
kelvinhammond wants to merge 6 commits into
mainfrom
update_libzim9.7.0
Open

Update libzim 9.7.0#201
kelvinhammond wants to merge 6 commits into
mainfrom
update_libzim9.7.0

Conversation

@kelvinhammond
Copy link
Copy Markdown
Collaborator

@kelvinhammond kelvinhammond commented May 11, 2026 •
edited by kelson42
Loading

Fixes #199
Fixes #200

  • Added missing addAlias
  • Bumped libzim to 9.7.0

@kelvinhammond kelvinhammond requested a review from kelson42 May 11, 2026 13:55
@kelvinhammond
Copy link
Copy Markdown
Collaborator Author

kelvinhammond commented May 11, 2026

Didn't build or test this locally, waiting for the github workflow to do that.

@kelson42 kelson42 requested a review from benoit74 May 11, 2026 13:56
@kelson42
Copy link
Copy Markdown
Contributor

kelson42 commented May 11, 2026

@kelvinhammond Thank you, Putting @benoit74 as reviewer for the new alias related code. But first we need to fix the CI.

@kelson42 kelson42 changed the title Update libzim9.7.0 Update libzim 9.7.0 May 11, 2026
@kelvinhammond
Copy link
Copy Markdown
Collaborator Author

kelvinhammond commented May 11, 2026

@kelvinhammond Thank you, Putting @benoit74 as reviewer for the new alias related code. But first we need to fix the CI.

Sorry, I was still in progress. Check now.

kelson42
kelson42 approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benoit74
benoit74 requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

I'm a bit surprised the addAlias method was not already implemented, but I'm glad it is now done.

Please add 2 entries (one per issue solved) to Changelog file and we are good to merge.

benoit74
benoit74 requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rewrite commits so that we have only 2 commits on top of main branch, one per issue solved, with appropriate CHANGELOG entry attached to each of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoit74 benoit74 benoit74 requested changes

@kelson42 kelson42 kelson42 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add addAlias to libzim Archive Use libzim 9.7.0

4 participants

@kelvinhammond @kelson42 @benoit74 @code-factor